Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ga): fix for #606 issue #613

Merged
merged 11 commits into from
Sep 11, 2024
Merged

fix(ga): fix for #606 issue #613

merged 11 commits into from
Sep 11, 2024

Conversation

eouin
Copy link
Contributor

@eouin eouin commented Sep 10, 2024

BUG - guide search is very inconsistent

#606

Description

  • add debounce on search input onChange callback
  • fix issue on pageSize from main...fix/606/search
  • cancel previous axios API call before doing another call

Checklist for Pull Requests

  • Supplied as many details as possible on this change
  • Included the link to the associated issue in the Issue section above
  • The code conforms to the general development guidelines.
  • The code has unit tests where applicable and is easily unit-testable
  • This branch is appropriately named for the associated issue

@eouin eouin requested a review from a team as a code owner September 10, 2024 17:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7e175e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap/guided-answers-extension-core Patch
sap-guided-answers-extension Patch
@sap/guided-answers-extension-webapp Patch
@sap/guided-answers-extension-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AlinaGovoruhina
AlinaGovoruhina previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@AlinaGovoruhina AlinaGovoruhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search functionality update and css changes look good to me, unit test coverage sufficient, did not test the application.

Klaus-Keller
Klaus-Keller previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eouin,

  • code changes look good and are easy to understand
  • change set exists
  • test coverage is good
  • did manual test, no issues found

Approved from my side.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hitesh-parmar
hitesh-parmar approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@hitesh-parmar hitesh-parmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All comments addressed
  • Functional test ✅

@eouin eouin merged commit 88c68a9 into main Sep 11, 2024
12 checks passed
@eouin eouin deleted the fix/ga/606/search-inconsistent-debounce-cancel branch September 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitesh-parmar hitesh-parmar hitesh-parmar approved these changes

@Klaus-Keller Klaus-Keller Klaus-Keller left review comments

@AlinaGovoruhina AlinaGovoruhina AlinaGovoruhina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eouin @hitesh-parmar @Klaus-Keller @AlinaGovoruhina